Push down NOT, IS NULL, NOT IS NULL in PostgreSQL connector by wendigo · Pull Request #11514 · trinodb/trino

wendigo · 2022-03-16T13:25:11Z

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Core query engine & PostgreSQL connector.

How would you describe this change to a non-technical end user or system administrator?

Enables pushdown of NOT expression and IS NULL, NOT IS NULL predicates in PostgreSQL connector

Related issues, pull requests, and links

#9506

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

#  PostgreSQL connector
* Improve performance of queries involving `IS NULL`, `IS NOT NULL` by pushing predicate
  computation to the underlying database. ({issue}`issuenumber`)
* Improve performance of queries involving `NOT`  by pushing expression
  computation to the underlying database. ({issue}`issuenumber`)

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/expression/TypePattern.java

findepi · 2022-03-16T14:05:36Z

@wendigo can you please rebase on top of #11515 ?

wendigo · 2022-03-16T14:16:46Z

@findepi done

findepi

"Translate NOT, IS NULL, NOT IS NULL to connector expression(s)"

core/trino-main/src/main/java/io/trino/sql/planner/ConnectorExpressionTranslator.java

core/trino-main/src/test/java/io/trino/sql/planner/BenchmarkPlanner.java

core/trino-main/src/main/java/io/trino/sql/planner/ConnectorExpressionTranslator.java

hashhar · 2022-03-16T23:47:19Z

plugin/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlClient.java

stale comment?

plugin/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlClient.java

hashhar · 2022-03-16T23:48:09Z

...n/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlConnectorTest.java

Let's also test with a column that actually contains NULLs.

Also IS NULL is possible to represent as a TupleDomain (none) so should we add an OR to ensure expression pushdown path?

findepi

"Translate NOT, IS NULL, NOT IS NULL to connector expression(s)"

findepi · 2022-03-21T14:41:01Z

core/trino-main/src/test/java/io/trino/sql/planner/TestConnectorExpressionTranslator.java

NotIsNull -> IsNotNull

findepi

"Implement NOT, IS NULL, NOT IS NULL pushdown in PostgreSQL connector"

findepi · 2022-03-21T14:44:13Z

...n/trino-postgresql/src/test/java/io/trino/plugin/postgresql/TestPostgreSqlConnectorTest.java

NOT (a OR b) can be replaced with (NOT a) AND (NOT b).

The test still would test what it tests, but having NOT around LIKE only would make it simpler.
Please change.

findepi · 2022-03-21T14:44:33Z

LGTM % comments.

findepi · 2022-03-21T14:48:17Z

(applied myself)

cla-bot bot added the cla-signed label Mar 16, 2022

wendigo requested review from findepi and hashhar and removed request for findepi March 16, 2022 13:25

wendigo commented Mar 16, 2022

View reviewed changes

plugin/trino-base-jdbc/src/main/java/io/trino/plugin/jdbc/expression/TypePattern.java Outdated Show resolved Hide resolved

wendigo requested a review from findepi March 16, 2022 13:27

wendigo changed the title ~~Pushdown NOT, IS NULL, NOT IS NULL in PostgreSQL connector~~ Push down NOT, IS NULL, NOT IS NULL in PostgreSQL connector Mar 16, 2022

wendigo force-pushed the serafin/expression-pushdown-support branch from 5c9367b to c0bcdf7 Compare March 16, 2022 14:16

findepi mentioned this pull request Mar 16, 2022

Extend expression pushdown support #9506

Open

findepi reviewed Mar 16, 2022

View reviewed changes

wendigo force-pushed the serafin/expression-pushdown-support branch from b3eea04 to 74a07e5 Compare March 16, 2022 17:01

wendigo requested a review from findepi March 16, 2022 17:02

hashhar reviewed Mar 16, 2022

View reviewed changes

ebyhr mentioned this pull request Mar 17, 2022

Push down NULLIF in PostgreSQL connector #11532

Merged

wendigo force-pushed the serafin/expression-pushdown-support branch 2 times, most recently from c03af14 to 2f7bf47 Compare March 21, 2022 11:29

findepi reviewed Mar 21, 2022

View reviewed changes

core/trino-main/src/test/java/io/trino/sql/planner/TestConnectorExpressionTranslator.java Outdated

Copy link
Copy Markdown

Member

findepi Mar 21, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NotIsNull -> IsNotNull

findepi reviewed Mar 21, 2022

View reviewed changes

wendigo added 2 commits March 21, 2022 15:46

Translate NOT, IS NULL, NOT IS NULL to connector expression(s)

7100a58

Implement NOT, IS NULL, NOT IS NULL pushdown in PostgreSQL connector

3a20817

findepi force-pushed the serafin/expression-pushdown-support branch from 2f7bf47 to 3a20817 Compare March 21, 2022 14:48

findepi approved these changes Mar 21, 2022

View reviewed changes

assaf2 self-requested a review March 21, 2022 17:42

assaf2 approved these changes Mar 21, 2022

View reviewed changes

hashhar approved these changes Mar 22, 2022

View reviewed changes

findepi merged commit 5e500ef into trinodb:master Mar 22, 2022

github-actions bot added this to the 375 milestone Mar 22, 2022

findepi mentioned this pull request Mar 22, 2022

Release notes for 375 #11527

Closed

wendigo deleted the serafin/expression-pushdown-support branch March 22, 2022 09:31

mosabua mentioned this pull request Mar 22, 2022

Add Trino 375 release notes #11528

Merged

hackeryang mentioned this pull request Jan 15, 2024

Support integer arithmetic, IS (NOT) NULL, NULLIF pushdown in MySQL connector #20378

Closed

Conversation

wendigo commented Mar 16, 2022

Description

Related issues, pull requests, and links

Documentation

Release notes

Uh oh!

Uh oh!

findepi commented Mar 16, 2022

Uh oh!

wendigo commented Mar 16, 2022

Uh oh!

findepi left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

hashhar Mar 16, 2022

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hashhar Mar 16, 2022

Choose a reason for hiding this comment

Uh oh!

hashhar Mar 16, 2022

Choose a reason for hiding this comment

Uh oh!

findepi left a comment

Choose a reason for hiding this comment

Uh oh!

findepi Mar 21, 2022

Choose a reason for hiding this comment

Uh oh!

findepi left a comment

Choose a reason for hiding this comment

Uh oh!

findepi Mar 21, 2022

Choose a reason for hiding this comment

Uh oh!

findepi commented Mar 21, 2022

Uh oh!

findepi commented Mar 21, 2022

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants