Translate arithmetic to connector expression#11511
Merged
findepi merged 2 commits intotrinodb:masterfrom Mar 21, 2022
Merged
Conversation
wendigo
approved these changes
Mar 16, 2022
core/trino-main/src/main/java/io/trino/sql/planner/ConnectorExpressionTranslator.java
Outdated
Show resolved
Hide resolved
hashhar
approved these changes
Mar 17, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM % possible improvement to test.
core/trino-main/src/main/java/io/trino/sql/planner/ConnectorExpressionTranslator.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/sql/planner/TestConnectorExpressionTranslator.java
Outdated
Show resolved
Hide resolved
findepi
force-pushed
the
findepi/translate-arithmetic-to-connector-expression-f74ff0
branch
from
39547d2 to
7652a39
Compare
findepi
force-pushed
the
findepi/translate-arithmetic-to-connector-expression-f74ff0
branch
2 times, most recently
from
ab3bbfe to
25fcbf4
Compare
Member
Author
findepi
force-pushed
the
findepi/translate-arithmetic-to-connector-expression-f74ff0
branch
from
25fcbf4 to
ee1edf9
Compare
Member
Author
|
rebased on top of #11567 |
losipiuk
reviewed
Mar 18, 2022
Member
Author
There was a problem hiding this comment.
3 minutes, this is the default optimizer timeout. The test is fixed, however, within the PR. (#11567)
Member
Author
There was a problem hiding this comment.
btw i didn't lower optimizer timeout in tests, because this needs to account for fetching metadata from remote systems, so could lead to test flakiness .
losipiuk
approved these changes
Mar 18, 2022
findepi
force-pushed
the
findepi/translate-arithmetic-to-connector-expression-f74ff0
branch
from
ee1edf9 to
0f1a658
Compare
findepi
force-pushed
the
findepi/translate-arithmetic-to-connector-expression-f74ff0
branch
from
0f1a658 to
8d04de9
Compare
Member
Author
|
Rebased after #11567 merged. |
findepi
commented
Mar 21, 2022
| List.of(symbolReference1, dereferenceExpression1)); | ||
|
|
||
| assertPartialTranslation( | ||
| new CoalesceExpression( |
Member
Author
findepi
deleted the
findepi/translate-arithmetic-to-connector-expression-f74ff0
branch
findepi
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #11510