Support reading Postgres array as JSON#1148
Merged
findepi merged 2 commits intotrinodb:masterfrom Oct 14, 2019
Merged
Conversation
kasiafi
force-pushed
the
PostgresArrayToJson
branch
2 times, most recently
from
7b7597a to
b2d7816
Compare
Member
Author
|
Issue: #682 |
Member
Author
|
cc @guyco33 |
kokosing
reviewed
Jul 25, 2019
| @@ -25,16 +25,19 @@ | |||
| import io.prestosql.spi.connector.ConnectorSplitManager; | |||
Member
There was a problem hiding this comment.
Can you please extract this commit as separate PR so we could merge this without blocking on postgres changes?
kasiafi
force-pushed
the
PostgresArrayToJson
branch
2 times, most recently
from
5fbaa50 to
851a264
Compare
findepi
changed the title
kasiafi
force-pushed
the
PostgresArrayToJson
branch
from
851a264 to
14867ed
Compare
findepi
approved these changes
Oct 11, 2019
Member
There was a problem hiding this comment.
else is redundant since if clause always returns
Member
There was a problem hiding this comment.
you should rather throw here:
throw new IllegalStateException("Unsupported array mapping type: " + getArrayMapping(session));
Member
There was a problem hiding this comment.
Assign getArrayMapping(session) to a variable and reuse.
Member
There was a problem hiding this comment.
checkArgument(jdbcArray.getClass().isArray(), "jdbcArray is not an array");
14867ed to
7f8c0cb
Compare
kasiafi
force-pushed
the
PostgresArrayToJson
branch
from
7f8c0cb to
1832c36
Compare
Member
Author
|
Applied comments |
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #682