Add documentation for Iceberg Glue catalog#11470
Conversation
|
Adding the WIP label until the code changes are actually merged. |
There was a problem hiding this comment.
Link to that section in the Hive connector docs
There was a problem hiding this comment.
We never talk about "catalog types" anywhere. Just say that two different metastores are supported.
There was a problem hiding this comment.
Why are we introducing a new concept of catalog type .. this is inconsistent with all other connectors. I would refactor this to be in line with Hive connector .. or at least something more logical like iceberge.metastore.type
There was a problem hiding this comment.
Catalog type should be a familiar term to Iceberg users. It doesn't refer to Trino Catalogs. https://iceberg.apache.org/docs/latest/spark-configuration/#catalogs
There was a problem hiding this comment.
I don't think we should use the word "Generic" here.
There was a problem hiding this comment.
General?
or "Iceberg configuration properties" like at https://trino.io/docs/current/connector/hive.html#hive-configuration-properties
(btw we seem to be using "Sentence case" and not "Upper Case" for section headers)
There was a problem hiding this comment.
I like "General configuration"
And yes, will fix capitalization, thanks
alexjo2144
force-pushed
the
iceberg-glue-docs
branch
from
1cb3fd2 to
1f35498
Compare
|
Updated, and removed the WIP label since the code PR was merged. |
3 participants
Description
Adds documentation for configuration of #10845
Documentation
Documentation
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: