Add estimates for filter nodes after an aggregation#11469
Merged
sopel39 merged 1 commit intotrinodb:masterfrom Mar 23, 2022
Merged
Add estimates for filter nodes after an aggregation#11469sopel39 merged 1 commit intotrinodb:masterfrom
sopel39 merged 1 commit intotrinodb:masterfrom
Conversation
sopel39
reviewed
Mar 14, 2022
core/trino-main/src/main/java/io/trino/cost/AggregationStatsRule.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
agg-stats
branch
from
4584630 to
b1df5b1
Compare
lukasz-stec
approved these changes
Mar 15, 2022
Member
lukasz-stec
left a comment
lukasz-stec
left a comment
There was a problem hiding this comment.
not an expert here but lgtm
core/trino-main/src/main/java/io/trino/cost/AggregationStatsRule.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
agg-stats
branch
3 times, most recently
from
c723a82 to
c681de0
Compare
raunaqmorarka
changed the title
raunaqmorarka
force-pushed
the
agg-stats
branch
7 times, most recently
from
0eda3a8 to
b63bcff
Compare
raunaqmorarka
force-pushed
the
agg-stats
branch
from
b63bcff to
9fe0626
Compare
Member
Author
sopel39
reviewed
Mar 17, 2022
core/trino-main/src/main/java/io/trino/SystemSessionProperties.java
Outdated
Show resolved
Hide resolved
sopel39
reviewed
Mar 21, 2022
core/trino-main/src/main/java/io/trino/SystemSessionProperties.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/sql/planner/OptimizerConfig.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/cost/FilterProjectAggregationStatsRule.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/cost/FilterProjectAggregationStatsRule.java
Outdated
Show resolved
Hide resolved
raunaqmorarka
force-pushed
the
agg-stats
branch
2 times, most recently
from
a1bdd0f to
547e6ac
Compare
sopel39
approved these changes
Mar 22, 2022
core/trino-main/src/test/java/io/trino/cost/TestFilterProjectAggregationStatsRule.java
Outdated
Show resolved
Hide resolved
Member
|
lgtm % comments |
Member
|
not that for only regression (partitioned q64) memory consumption for the query is greatly reduced, so it's still a win |
Added a flag optimizer.non-estimatable-predicate-approximation.enabled which enables approximation of the cost of filters which cannot be accurately estimated even with complete statistics.
raunaqmorarka
force-pushed
the
agg-stats
branch
from
547e6ac to
cd9033d
Compare
sopel39
approved these changes
Mar 23, 2022
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Added a flag optimizer.non-estimatable-predicate-approximation.enabled
which enables approximation of the cost of filters which cannot be
accurately estimated even with complete statistics.
improvement
CBO
Improves query plans in the presence of filters on aggregates.
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: