Migrate raptor connector to MySQL Connector/J 8.x#11450
Merged
hashhar merged 1 commit intotrinodb:masterfrom Apr 27, 2022
Merged
Migrate raptor connector to MySQL Connector/J 8.x#11450hashhar merged 1 commit intotrinodb:masterfrom
hashhar merged 1 commit intotrinodb:masterfrom
Conversation
findepi
approved these changes
Mar 14, 2022
pom.xml
Outdated
Member
Author
There was a problem hiding this comment.
Assuming that's the airlift version which includes airlift/airlift#986.
This PR is blocked until newer airlift is released.
Member
|
Can you see what it would look like to inline the necessary configuration code for H2 and MySQL? It would be better if we can deprecate the dbpool module. |
Member
Author
|
I'll take a look @electrum. If it's a larger lift I'd create a separate PR. |
hashhar
force-pushed
the
hashhar/mysql-8
branch
from
86023ec to
edcf658
Compare
Upgrading to Connector/J 8.x allows using both MySQL 5.x and 8.x with raptor plugin.
hashhar
force-pushed
the
hashhar/mysql-8
branch
from
edcf658 to
c5f74e3
Compare
Member
Author
|
rebased. I couldn't see way to remove dbpool without loosing features (i.e. connecting to sharded MySQL setup). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: Depends on airlift/airlift#986 and will require a new airlift release
Description
Upgrading to Connector/J 8.x allows using both MySQL 5.x and 8.x with
raptor plugin.
Related issues, pull requests, and links
Fixes #8302
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: