Closed
Conversation
ba9461f to
0245b60
Compare
kyo-tom
commented
Mar 11, 2022
| public enum ConnectorCapabilities | ||
| { | ||
| NOT_NULL_COLUMN_CONSTRAINT, | ||
| COMMENT_ON_TABLE, |
Contributor
Author
There was a problem hiding this comment.
It should be add into MongoConnector after the pr #11424 merged
Member
There was a problem hiding this comment.
per #11348 (comment) i think it's too late to add this to ConnectorCapabilities. The damage has been done and the ship has sailed. Adding this now would be a breaking change.
Member
There was a problem hiding this comment.
Agreed. Instead I'd suggest to add a test to BaseConnectorTest that asserts that COMMENT ON TABLE works.
For the connectors where it fails you need to disallow it in their ConnectorMetadata implementations. (as discussed on #11348 (comment))
Contributor
Author
Member
|
Superseded by #11493 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Deny comment on unsupported table
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: