Improve MySQL type mapping tests#11382
Merged
ebyhr merged 2 commits intotrinodb:masterfrom Mar 10, 2022
Merged
Conversation
6 tasks
hashhar
approved these changes
Mar 9, 2022
ebyhr
reviewed
Mar 9, 2022
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/TestMySqlTypeMapping.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/TestMySqlTypeMapping.java
Outdated
Show resolved
Hide resolved
tangjiangling
force-pushed
the
separate-mysql-testBasicTypes
branch
from
c56faa0 to
b554ef9
Compare
ebyhr
approved these changes
Mar 9, 2022
Member
|
@tangjiangling CI failure looks related. |
hashhar
reviewed
Mar 9, 2022
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/TestMySqlTypeMapping.java
Outdated
Show resolved
Hide resolved
Member
Author
This commit includes: - Add separate tests for MySQL tinyint/smallint/integer/bigint - Add min/max/min-1/max+1 test cases - Cover more tests using trinoCreateAndInsert in TestMySqlTypeMapping - Remove unnecessary tpch from tableNamePrefix - Reuse trinoCreateAndInsert in TestMySqlTypeMapping - Remove duplicate characters
tangjiangling
force-pushed
the
separate-mysql-testBasicTypes
branch
from
b554ef9 to
874dcb1
Compare
Member
Author
|
CI (maven-checks 11/17) https://github.com/trinodb/trino/runs/5478810967?check_suite_focus=true Fixed by #11393 I'll push an empty commit to retrigger the CI. |
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit includes:
Description
Improvement.
MySQL type mapping tests.
N/A.
Related issues, pull requests, and links
Related #11181
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: