Skip to content

Improve description and visiblity of the properties reference#11375

Merged
hashhar merged 1 commit intotrinodb:masterfrom
jhlodin:jl/general-properties
Mar 9, 2022
Merged

Improve description and visiblity of the properties reference#11375
hashhar merged 1 commit intotrinodb:masterfrom
jhlodin:jl/general-properties

Conversation

@jhlodin
Copy link
Copy Markdown
Contributor

@jhlodin jhlodin commented Mar 8, 2022

Description

The properties reference is unclear that it is not a complete list of all available properties, and also that it doesn't include catalog configuration properties. This PR improves that description and links with context in the deployment guide.

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Documentation

How would you describe this change to a non-technical end user or system administrator?

This change makes it easier to find and understand the Trino properties reference docs.

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Mar 8, 2022
@jhlodin jhlodin requested review from Ordinant, hashhar and mosabua March 8, 2022 18:30
@jhlodin jhlodin added the docs label Mar 8, 2022
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me.

Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Definitely clarifies and direct users to more useful resources.

@hashhar hashhar merged commit e7e2a82 into trinodb:master Mar 9, 2022
@github-actions github-actions bot added this to the 373 milestone Mar 9, 2022
@jhlodin jhlodin deleted the jl/general-properties branch March 9, 2022 15:44
v-jizhang added a commit to v-jizhang/presto that referenced this pull request Mar 15, 2022
Cherry-pick of trinodb/trino#11375

Co-authored-by: Joe Lodin <joe.lodin@starburstdata.com>
tdcmeehan pushed a commit to prestodb/presto that referenced this pull request Mar 17, 2022
Cherry-pick of trinodb/trino#11375

Co-authored-by: Joe Lodin <joe.lodin@starburstdata.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants