Add support for COMMENT ON VIEW statement#11359
Merged
ebyhr merged 3 commits intotrinodb:masterfrom Jul 11, 2022
Merged
Conversation
ebyhr
force-pushed
the
ebi/comment-on-view
branch
from
a2baab4 to
7be1049
Compare
Member
Author
|
CI #11368 |
Member
raunaqmorarka
left a comment
raunaqmorarka
left a comment
There was a problem hiding this comment.
It would be good to add support for this to hive and iceberg connectors as well (as separate commits)
plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemoryMetadata.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/test/java/io/trino/connector/MockConnector.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/CommentTask.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/comment-on-view
branch
from
7be1049 to
f519c21
Compare
ebyhr
force-pushed
the
ebi/comment-on-view
branch
from
f519c21 to
56d1aad
Compare
Member
Author
|
Just rebased on upstream. |
Member
Author
I want to separate PR for Hive and Iceberg support. |
Member
raunaqmorarka
left a comment
raunaqmorarka
left a comment
There was a problem hiding this comment.
minor comments, lgtm otherwise
plugin/trino-memory/src/main/java/io/trino/plugin/memory/MemoryMetadata.java
Outdated
Show resolved
Hide resolved
testing/trino-testing/src/main/java/io/trino/testing/BaseConnectorTest.java
Outdated
Show resolved
Hide resolved
ebyhr
force-pushed
the
ebi/comment-on-view
branch
from
56d1aad to
3cd289b
Compare
raunaqmorarka
approved these changes
Jul 10, 2022
Closed
utk-spartan
added a commit
to utk-spartan/ranger
that referenced
this pull request
Jul 19, 2022
Incorporate following changes Add support for COMMENT ON VIEW statement trinodb/trino#11359 trinodb/trino@241e0be
utk-spartan
added a commit
to utk-spartan/ranger
that referenced
this pull request
Jul 19, 2022
Incorporate following changes Add support for COMMENT ON VIEW statement trinodb/trino#11359 trinodb/trino@241e0be
utk-spartan
added a commit
to razorpay/ranger
that referenced
this pull request
Jul 19, 2022
Incorporate following changes Add support for COMMENT ON VIEW statement trinodb/trino#11359 trinodb/trino@241e0be
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add support for
COMMENT ON VIEWstatementRelated issues, pull requests, and links
Documentation
( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: