Skip to content

Deny wrong null replacement of array type in Phoenix connector#11351

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/phoenix-verify-nulls
Mar 8, 2022
Merged

Deny wrong null replacement of array type in Phoenix connector#11351
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/phoenix-verify-nulls

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Mar 7, 2022

Description

Deny wrong null replacement of array type in Phoenix connector

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Section
* Prevent incorrect query results by failing a query when Phoenix JDBC driver replaces `null` elements with different values in an array. ({issue}`11351 `)

@cla-bot cla-bot bot added the cla-signed label Mar 7, 2022
@ebyhr ebyhr force-pushed the ebi/phoenix-verify-nulls branch from f54ab81 to 3f89131 Compare March 7, 2022 23:48
@ebyhr ebyhr requested a review from hashhar March 8, 2022 07:30
@hashhar hashhar requested a review from lhofhansl March 8, 2022 07:34
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. We'll now prevent silent corruption during writes.

@hashhar
Copy link
Copy Markdown
Member

hashhar commented Mar 8, 2022

Is there any upstream issue that already exists? If so, please add a TODO referring to it (or refer to #6421 itself)

@ebyhr ebyhr force-pushed the ebi/phoenix-verify-nulls branch from 3f89131 to 7a76f77 Compare March 8, 2022 08:34
@ebyhr ebyhr merged commit 73c18ac into trinodb:master Mar 8, 2022
@ebyhr ebyhr deleted the ebi/phoenix-verify-nulls branch March 8, 2022 09:27
@ebyhr ebyhr mentioned this pull request Mar 8, 2022
@github-actions github-actions bot added this to the 373 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Array with double null stored as array with 0 in Phoenix

2 participants