Make user property optional in JDBC

[lukasz-walkiewicz]

Description

user property is only required in two scenarios:

• no authentication - in this case the server will return a well-formed
  error,
• basic authentication - the driver will validate the configuration and
  return an error if only password was provided.

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# JDBC Driver
* Remove `user` property requirement

Fixes: #9669

[kokosing]

Can we remove things like the below from product tests that are using KRB or other authentications methods and use user mapping instead there?

    #   1) It should belong to the "admin" role in hive
    #   2) It should have the required privileges (such as SELECT) on Hive tables (such as hive.default.nation)
    jdbc_user: hdfs
  

[findepi]

--user option in case of CLI and user property in case of JDBC is only required when no or basic authentication is being used. In the first case server will return a well-formed error

I'd strongly prefer to avoid breaking change like this when no authentication is used.
It should actually be easy to do.

(if i were reviewing this PR, it would be 'must have' change; i am currently not reviewing this)

[electrum]

It’s good to make it optional, but we shouldn’t make it a breaking change. Let’s allow setting it to empty to indicate that it shouldn’t be sent.

[electrum]

JDBC and CLI are different and the behavior needs to be considered separately. Can you create separate pull requests?

[lukasz-walkiewicz]

JDBC and CLI are different and the behavior needs to be considered separately. Can you create separate pull requests?

I've removed CLI related changes from this PR. I'll create a seperate PR.

[lukasz-walkiewicz]

Can we remove things like the below from product tests that are using KRB or other authentications methods and use user mapping instead there?

    #   1) It should belong to the "admin" role in hive
    #   2) It should have the required privileges (such as SELECT) on Hive tables (such as hive.default.nation)
    jdbc_user: hdfs
  

I removed it but this cause a lot of product test failures. I tried to replace it with user mapping but it didn't work: it was using jdbc_user from testing/trino-product-tests/src/main/resources/tempto-configuration.yaml. Also, it's not possible to simply delete jdbc_user at the moment, Tempto requires it.

[kokosing]

@electrum Do you want to take a look into this? There are no more breaking changes, so I would like to merge it.

[lukasz-walkiewicz]

CI hit: #6315

[lukasz-walkiewicz]

Any updates on this @electrum?

[leniartek]

@lukasz-walkiewicz @kokosing please merge as this was positively reviewed 21 days ago.

[kokosing]

Merged, thanks!