Skip to content

Clean extra output files when overwriting a partition#11335

Merged
losipiuk merged 2 commits intotrinodb:masterfrom
losipiuk:lo/insert_existing_duplicate_rows_bug
Mar 8, 2022
Merged

Clean extra output files when overwriting a partition#11335
losipiuk merged 2 commits intotrinodb:masterfrom
losipiuk:lo/insert_existing_duplicate_rows_bug

Conversation

@losipiuk
Copy link
Copy Markdown
Member

@losipiuk losipiuk commented Mar 4, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Hive connector

How would you describe this change to a non-technical end user or system administrator?

Fix issue when duplicate rows could be inserted into partition when insert_existing_partitions_behavior
was set to OVERWRITE and retry-policy was TASK.

Related issues, pull requests, and links

fixes: #11196

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# Hive connector
* Fix issue when duplicate rows could be inserted into partition when ``insert_existing_partitions_behavior`` 
   was set to ``OVERWRITE`` and ``retry-policy`` was ``TASK``. ({issue}`11196`)

@cla-bot cla-bot bot added the cla-signed label Mar 4, 2022
@losipiuk losipiuk force-pushed the lo/insert_existing_duplicate_rows_bug branch from e0cee21 to f3e86ca Compare March 4, 2022 21:39
@losipiuk losipiuk requested review from arhimondr and findepi March 4, 2022 21:40
@losipiuk losipiuk force-pushed the lo/insert_existing_duplicate_rows_bug branch from f3e86ca to 4d9a2fc Compare March 7, 2022 12:57
@losipiuk
Copy link
Copy Markdown
Member Author

losipiuk commented Mar 8, 2022

CI: #10772

@losipiuk losipiuk merged commit 4958688 into trinodb:master Mar 8, 2022
@github-actions github-actions bot added this to the 373 milestone Mar 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

insert_existing_partitions_behavior OVERWRITE does not work correctly on S3 with task level retries.

2 participants