Remove trino-testing dependency on trino-exchange#11311
Closed
findepi wants to merge 2 commits intotrinodb:masterfrom
Closed
Remove trino-testing dependency on trino-exchange#11311findepi wants to merge 2 commits intotrinodb:masterfrom
findepi wants to merge 2 commits intotrinodb:masterfrom
Conversation
findepi
commented
Mar 3, 2022
findepi
force-pushed
the
findepi/un-exchange
branch
from
f883956 to
4a5c8ec
Compare
losipiuk
approved these changes
Mar 3, 2022
nineinchnick
approved these changes
Mar 3, 2022
nineinchnick
reviewed
Mar 3, 2022
plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseHiveConnectorTest.java
Outdated
Show resolved
Hide resolved
electrum
approved these changes
Mar 3, 2022
`trino-exchange` has lots of dependencies, and `trino-testing` is used in all modules. This causes classpath conflicts which were not detected because maven dependency checker was not being run (fixed in airbase 122). This commit adds a bit of code duplication, but reduces dependencies.
findepi
force-pushed
the
findepi/un-exchange
branch
from
4a5c8ec to
c52b683
Compare
Was renamed in f85eaab.
Member
Author
|
That was nice, but didn't work. The exchange plugin needs to be installed before tables are provisioned, so typically during PTAL |
losipiuk
approved these changes
Mar 4, 2022
Member
Author
|
Incorporated into #11309 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
trino-exchangehas lots of dependencies, andtrino-testingis usedin all modules. This causes classpath conflicts which were not detected
because maven dependency checker was not being run (fixed in airbase
122).
This commit adds a bit of code duplication, but reduces dependencies.