Skip test-docs job when PR contains release-notes label#11291
Skip test-docs job when PR contains release-notes label#11291ebyhr merged 1 commit intotrinodb:masterfrom
Conversation
Let test-docs run, or skip test-docs run? I think I'm confused. BTW what's the rationale for the change, unless it's obvious? |
|
@findepi "Let test-docs run" is the expected message. We could rephrase it as: "Let test-docs skip when PR contains release-notes label". The motivation is reducing CI queue more as we use the label only for release notes PR that doesn't require the tests at this time. https://github.com/trinodb/trino/pulls?q=is%3Apr+label%3Arelease-notes |
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Makes sense to me, we still run the doc checks, just skip the other trino modules.
Maybe Skip test-docs job when PR contains release-notes label with some context in body that it's safe to do since docs-checks would still run?
The label is used only for release notes that don't require tests. Another docs-checks job to verify "trino-docs" module would still run.
ebyhr
force-pushed
the
ebi/docs-skip-release-note
branch
from
83ca864 to
58dfcf4
Compare
ebyhr
changed the title
3 participants
Description
Let test-docs run when PR doesn't contain
release-noteslabel.Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.