Skip to content

Add client and source tags to resource group documentation#11287

Merged
hashhar merged 3 commits intotrinodb:masterfrom
Jessie212:jt/jdbc-connection-properties
Mar 17, 2022
Merged

Add client and source tags to resource group documentation#11287
hashhar merged 3 commits intotrinodb:masterfrom
Jessie212:jt/jdbc-connection-properties

Conversation

@Jessie212
Copy link
Copy Markdown
Contributor

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Addition to documentation.

How would you describe this change to a non-technical end user or system administrator?

Add client and source tags to resource group documentation

Related issues, pull requests, and links

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@cla-bot cla-bot bot added the cla-signed label Mar 2, 2022
@Jessie212 Jessie212 requested review from Ordinant and mosabua March 2, 2022 22:47
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a bunch of updates..

@mosabua mosabua added the docs label Mar 2, 2022
@Jessie212 Jessie212 force-pushed the jt/jdbc-connection-properties branch from 398a2f7 to 166c27f Compare March 11, 2022 22:11
@mosabua mosabua requested review from electrum and hashhar March 16, 2022 19:36
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM % nit

nit: JDBC used in -> JDBC driver as used in/JDBC driver when used in/with?

@Jessie212 Jessie212 force-pushed the jt/jdbc-connection-properties branch from 166c27f to 361f893 Compare March 16, 2022 20:54
@hashhar hashhar merged commit 7d104ad into trinodb:master Mar 17, 2022
@github-actions github-actions bot added this to the 375 milestone Mar 17, 2022
@Jessie212 Jessie212 deleted the jt/jdbc-connection-properties branch March 18, 2022 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants