Skip to content

Document DEFAULT keyword as a reserved term #11285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jhlodin wants to merge 1 commit into from
Closed

Document DEFAULT keyword as a reserved term #11285

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/src/main/sphinx/language/reserved.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ Keyword SQL:2016 SQL-92
``CURRENT_TIMESTAMP`` reserved reserved
``CURRENT_USER`` reserved
``DEALLOCATE`` reserved reserved
``DEFAULT`` reserved reserved
Copy link
Copy Markdown
Member

@ebyhr ebyhr Mar 2, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DEFAULT isn't a reserved keyword in Trino at this time. That is why docs-checks job is failing.
https://github.com/trinodb/trino/blob/master/core/trino-parser/src/main/antlr4/io/trino/sql/parser/SqlBase.g4#L707-L712

Copy link
Copy Markdown
Contributor Author

@jhlodin jhlodin Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I'm misunderstanding, I thought that DEFAULT being an accepted keyword in, at least, the ... SET PROPERTIES foo = DEFAULT context would mean that it's reserved?

Copy link
Copy Markdown
Member

@kasiafi kasiafi Mar 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally try not to make keywords reserved unless there's a potential ambiguity. I don't think that's the case with DEFAULT. Also, making it reserved would likely cause backwards-compatibility issues.

``DELETE`` reserved reserved
``DESCRIBE`` reserved reserved
``DISTINCT`` reserved reserved
Expand Down