Add debug log to BigQuery ReadRowsHelper#11276
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Mar 28, 2022
Merged
Conversation
findepi
reviewed
Mar 2, 2022
Member
There was a problem hiding this comment.
logging a stacktrace and retrying isn't good, as this may easily flood logs, and with something that's not actionable.
if the attempt is retried, this should probably go on debug
if the attempt is not retried, this doesn't need to be logged at all
ebyhr
changed the title
findepi
approved these changes
Mar 25, 2022
plugin/trino-bigquery/src/main/java/io/trino/plugin/bigquery/ReadRowsHelper.java
Outdated
Show resolved
Hide resolved
Add some logs in the connector because BigQuery library doesn't leave helpful logs even with TRACE level.
ebyhr
added
the
no-release-notes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add debug log to BigQuery ReadRowsHelper
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.