Add redirection awareness for SHOW GRANTS statement#11270
Add redirection awareness for SHOW GRANTS statement#11270findepi merged 1 commit intotrinodb:masterfrom
Conversation
There was a problem hiding this comment.
@phd3 there is also a TODO comment here:
trino/core/trino-main/src/main/java/io/trino/metadata/MetadataManager.java
Lines 2025 to 2027 in 2e3f9d5
Am I correct in assuming that handling the MetadataManager#listTablePrivileges is not in the scope of this PR ?
...no-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToIceberg.java
Outdated
Show resolved
Hide resolved
|
In the comment #10577 (comment) the why? for disallowing redirects on |
core/trino-main/src/main/java/io/trino/sql/rewrite/ShowQueriesRewrite.java
Outdated
Show resolved
Hide resolved
...no-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveRedirectionToIceberg.java
Outdated
Show resolved
Hide resolved
2360409 to
c65eaf2
Compare
|
@findinpath sorry for the delayed response here.
seems reasonable.
IIRC the coherency point was only for show-create, and not grants. |
Description
Disallow table redirection for the
SHOW GRANTSstatement.New feature.
This change affects the core query engine.
Performing automatic table redirection behind the scenes within the
SHOW GRANTSstatement is disallowed as pointed out in #11202Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: