Increase timeout in container test#11257
Merged
findepi merged 1 commit intotrinodb:masterfrom Mar 2, 2022
Merged
Conversation
Member
Add this to commit description please. |
raunaqmorarka
approved these changes
Mar 1, 2022
When the container healthcheck was added, it also replaced looping over trino-cli in the container test script with docker inspect. Since executing trino-cli could time out after the container started but before the server was ready, it actually added to the total timeout of the loop. Now, none of the commands in the loop are blocking for longer periods, so the timeout is easier to control. It was measured that the container can take up to 7 minutes to start on arm64 using emulation, so the timeout is raised to 10 minutes.
nineinchnick
force-pushed
the
container-test-timeouts
branch
from
8e7b087 to
d57903b
Compare
Member
|
Previous build https://github.com/trinodb/trino/actions/runs/1917207395 green except for #11275 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When #10413 added a healthcheck, it also replaced looping over
trino-cliin the container test script withdocker inspect. Since executingtrino-clicould time out after the container started but before the server was ready, it actually added to the total timeout of the loop. Now, none of the commands in the loop are blocking for longer periods, so the timeout is easier to control.We measured that the container can take up to 7 minutes to start on arm64 using emulation, so I suggest setting the timeout to 10 minutes.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: