Fix node cleanup for MemSQL tests#11231
Merged
hashhar merged 1 commit intotrinodb:masterfrom Feb 28, 2022
Merged
Conversation
nineinchnick
approved these changes
Feb 28, 2022
findepi
reviewed
Mar 1, 2022
| - name: Cleanup node | ||
| # This is required as a virtual environment update 20210219.1 left too little space for MemSQL to work | ||
| if: matrix.modules == ':trino-memsql' | ||
| if: matrix.modules == 'plugin/trino-memsql' |
Member
There was a problem hiding this comment.
could this use pattern matching or substring searching?
Member
Author
There was a problem hiding this comment.
Both contains and endsWith are available in GHA expressions.
Member
There was a problem hiding this comment.
awesome, let's do contains trino-mysql, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a missed instance of
:trino-memsqltoplugin/trino-memsqlwhen checking whether to run the CI cleanup step.