Skip to content

Add documentation for Delta Lake connector#11229

Merged
martint merged 1 commit intotrinodb:masterfrom
Jessie212:jt/delta-lake-connector-tr
Mar 9, 2022
Merged

Add documentation for Delta Lake connector#11229
martint merged 1 commit intotrinodb:masterfrom
Jessie212:jt/delta-lake-connector-tr

Conversation

@Jessie212
Copy link
Copy Markdown
Contributor

Description

Comprehensive documentation for the new Delta Lake connector. New properties, type-mapping, SQL support and more.

Is this change a fix, improvement, new feature, refactoring, or other?

Documentation for new feature.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

Delta Lake connector.

How would you describe this change to a non-technical end user or system administrator?

Add documentation for Delta Lake connector.

Related issues, pull requests, and links

Related to #10897

Documentation

( ) No documentation is needed.
(x) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

@mosabua
Copy link
Copy Markdown
Member

mosabua commented Mar 1, 2022

Just to be clear.. this PR is WIP for a reason .. we are not ready yet. Stay tuned until the label is gone.

@Jessie212 Jessie212 force-pushed the jt/delta-lake-connector-tr branch 2 times, most recently from dd97b6a to 0166a37 Compare March 1, 2022 22:18
Copy link
Copy Markdown
Member

@mosabua mosabua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A number of small changes needed to start off with. Now we really need a review from the developers for technical accuracy.. can you do that @jirassimok ? We need to collaborate to ensure that the code and doc PRs are getting ready for the same release. Also fyi @findepi @claudiusli @joshthoward

@mosabua mosabua requested a review from jirassimok March 8, 2022 16:23
@Jessie212 Jessie212 force-pushed the jt/delta-lake-connector-tr branch 2 times, most recently from 32e61be to ec47074 Compare March 8, 2022 22:23
Copy link
Copy Markdown
Member

@jirassimok jirassimok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick look, and probably missed some things, but the biggest change needed is that we don't support hive.security, so most related sections should be removed.

@Jessie212
Copy link
Copy Markdown
Contributor Author

I took a quick look, and probably missed some things, but the biggest change needed is that we don't support hive.security, so most related sections should be removed.

@kokosing I've applied all your suggestions. Thanks for the review.

@Jessie212 Jessie212 force-pushed the jt/delta-lake-connector-tr branch from ec47074 to 8c3c48e Compare March 9, 2022 14:46
@kokosing
Copy link
Copy Markdown
Member

kokosing commented Mar 9, 2022

@kokosing I've applied all your suggestions. Thanks for the review.

I think you wanted to mention @jirassimok

@Jessie212
Copy link
Copy Markdown
Contributor Author

@kokosing I've applied all your suggestions. Thanks for the review.

I think you wanted to mention @jirassimok

Sorry, @jirassimok. That message was meant for you. Thank you!

@Jessie212 Jessie212 force-pushed the jt/delta-lake-connector-tr branch from 8c3c48e to a1d9525 Compare March 9, 2022 16:56
@Jessie212 Jessie212 force-pushed the jt/delta-lake-connector-tr branch from a1d9525 to c0ad77a Compare March 9, 2022 20:54
@martint martint merged commit 6229380 into trinodb:master Mar 9, 2022
@Jessie212 Jessie212 deleted the jt/delta-lake-connector-tr branch March 9, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

8 participants