Skip to content

Don't exclude anything in test matrix if impacted modules list is empty#11228

Merged
hashhar merged 1 commit intotrinodb:masterfrom
nineinchnick:gib-on-master
Mar 1, 2022
Merged

Don't exclude anything in test matrix if impacted modules list is empty#11228
hashhar merged 1 commit intotrinodb:masterfrom
nineinchnick:gib-on-master

Conversation

@nineinchnick
Copy link
Copy Markdown
Member

Description

This is a follow up to #10323 that did not properly handled running GIB on the master branch. This PR ensures that:

  • the impacted modules log file gib-impacted.log always exists
  • nothing is excluded from the test matrix if the file is empty

Is this change a fix, improvement, new feature, refactoring, or other?
other - ci fix

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)
other - ci fix

How would you describe this change to a non-technical end user or system administrator?
n/a

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

(x) No release notes entries required.
( ) Release notes entries required with the following suggested text:

# Section
* Fix some things. ({issue}`issuenumber`)

@cla-bot cla-bot bot added the cla-signed label Feb 28, 2022
@hashhar hashhar merged commit 445c692 into trinodb:master Mar 1, 2022
@github-actions github-actions bot added this to the 372 milestone Mar 1, 2022
@nineinchnick nineinchnick deleted the gib-on-master branch March 1, 2022 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants