Run engine-only tests with task level retries#11224
Merged
losipiuk merged 9 commits intotrinodb:masterfrom Mar 2, 2022
Merged
Conversation
losipiuk
commented
Feb 28, 2022
Member
There was a problem hiding this comment.
add a word of comment?
Suggested change
| // TODO(https://github.com/trinodb/trino/issues/11223) | |
| // TODO(https://github.com/trinodb/trino/issues/11223) this doesn't work with retries |
findepi
approved these changes
Feb 28, 2022
Member
There was a problem hiding this comment.
if renaming, can we use Base.. convention?
Member
Author
There was a problem hiding this comment.
It will result in mixed convention for multiple similar tests. I would rather do it as a followup renaming all of those (also it is painful to change rename pattern with commits on top).
...hive/src/test/java/io/trino/plugin/hive/TestHiveFaultTolerantExecutionEngineOnlyQueries.java
Outdated
Show resolved
Hide resolved
...hive/src/test/java/io/trino/plugin/hive/TestHiveFaultTolerantExecutionEngineOnlyQueries.java
Outdated
Show resolved
Hide resolved
...hive/src/test/java/io/trino/plugin/hive/TestHiveFaultTolerantExecutionEngineOnlyQueries.java
Outdated
Show resolved
Hide resolved
losipiuk
force-pushed
the
lo/run-enging-only-tests-task-retries
branch
2 times, most recently
from
a00b1e9 to
c4670d5
Compare
arhimondr
approved these changes
Mar 1, 2022
losipiuk
force-pushed
the
lo/run-enging-only-tests-task-retries
branch
from
c4670d5 to
7bd9e9b
Compare
losipiuk
force-pushed
the
lo/run-enging-only-tests-task-retries
branch
from
7bd9e9b to
4716ec1
Compare
losipiuk
force-pushed
the
lo/run-enging-only-tests-task-retries
branch
from
4716ec1 to
6603cdb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test only change - no release notes/docs needed