Skip to content

Separate SqlServer testBasicTypes into multiple tests#11214

Merged
ebyhr merged 2 commits intotrinodb:masterfrom
tangjiangling:separate-sql-server-testBasicTypes
Mar 1, 2022
Merged

Separate SqlServer testBasicTypes into multiple tests#11214
ebyhr merged 2 commits intotrinodb:masterfrom
tangjiangling:separate-sql-server-testBasicTypes

Conversation

@tangjiangling
Copy link
Copy Markdown
Member

@tangjiangling tangjiangling commented Feb 28, 2022 •
edited by ebyhr
Loading

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Improvement.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

SqlServer type mapping tests.

How would you describe this change to a non-technical end user or system administrator?

N/A.

Related issues, pull requests, and links

Related #11181

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Feb 28, 2022
@tangjiangling tangjiangling mentioned this pull request Feb 28, 2022
Closed
6 tasks
@tangjiangling tangjiangling marked this pull request as ready for review February 28, 2022 07:27
@tangjiangling tangjiangling changed the title Separate sql server test basic types Separate sql server testBasicTypes Feb 28, 2022
@tangjiangling tangjiangling changed the title Separate sql server testBasicTypes Separate SqlServer testBasicTypes into multiple tests Feb 28, 2022
@tangjiangling tangjiangling force-pushed the separate-sql-server-testBasicTypes branch from 5cd48f1 to dadb529 Compare February 28, 2022 11:03
ebyhr
ebyhr approved these changes Mar 1, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for comments. Please check CI failure about "undeclared dependencies".

Also, you can squash the 3rd commit into 2nd commit wth the below commit message:

Improve SQL Server type mapping tests

@tangjiangling tangjiangling force-pushed the separate-sql-server-testBasicTypes branch from dadb529 to 6e38178 Compare March 1, 2022 07:46
@tangjiangling
Improve SQL Server type mapping tests
ad41b81 
This commit includes:

- Add separate tests for SQL Server bit/tinyint/smallint/integer/bigint
- Add min/max/min-1/max+1 test cases
- Cover more tests using trinoCreateAndInsert in BaseSqlServerTypeMapping
@tangjiangling tangjiangling force-pushed the separate-sql-server-testBasicTypes branch from 6e38178 to ad41b81 Compare March 1, 2022 13:18
@tangjiangling
Copy link
Copy Markdown
Member Author

tangjiangling commented Mar 1, 2022

Updated.

@ebyhr ebyhr merged commit 03f17e7 into trinodb:master Mar 1, 2022
@ebyhr
Copy link
Copy Markdown
Member

ebyhr commented Mar 1, 2022

Merged, thanks!

@mosabua mosabua mentioned this pull request Mar 1, 2022
Merged
@github-actions github-actions bot added this to the 372 milestone Mar 2, 2022
@tangjiangling tangjiangling deleted the separate-sql-server-testBasicTypes branch March 2, 2022 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ebyhr ebyhr ebyhr approved these changes

@findepi findepi Awaiting requested review from findepi

Assignees

No one assigned

Labels

cla-signed

Milestone

372

Development

Successfully merging this pull request may close these issues.

2 participants

@tangjiangling @ebyhr