Skip to content

Convert exception when failed to get columns in Phoenix#11212

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/phoenix-metadata-get-columns
Mar 7, 2022
Merged

Convert exception when failed to get columns in Phoenix#11212
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/phoenix-metadata-get-columns

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Feb 28, 2022 •
edited
Loading

Description

Convert exception when failed to get columns in Phoenix. Tested 30 invocations on #10844 locally.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.

Release notes

(x) Release notes entries required with the following suggested text:

# Phoenix
* Fix metadata listing failure in case of concurrent table deletion. ({issue}`10904`)

@cla-bot cla-bot bot added the cla-signed label Feb 28, 2022
@findepi
Copy link
Copy Markdown
Member

findepi commented Feb 28, 2022

Tested 30 invocations on #10844 locally.

when working with #10844 i had the problem that failures were not reproducible locally, even though would show up on CI easily. Different number of CPU cores perhaps?

Since in #10844 i already added test suppression after discovering #10904, removed it after #11134 was merged, and add it back after discovering #11134 (comment), can i suggest #10844 is merged before this one?

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Feb 28, 2022

can i suggest #10844 is merged before this one?

@findepi Sure, please go ahead. This is just fyi, but #10844 in Phoenix often failed without this commit in my laptop.

@findepi
Copy link
Copy Markdown
Member

findepi commented Feb 28, 2022

This is just fyi, but #10844 in Phoenix often failed without this commit in my laptop.

I was focused on Iceberg. Sorry for not mentioning that.

@ebyhr ebyhr force-pushed the ebi/phoenix-metadata-get-columns branch from aa8e63d to d35181f Compare March 7, 2022 05:23
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Mar 7, 2022

3/50 failed due to RetriesExhaustedException. The issue will be resolved by #11320

@ebyhr ebyhr force-pushed the ebi/phoenix-metadata-get-columns branch from d35181f to 69d6f0d Compare March 7, 2022 06:01
@ebyhr ebyhr requested a review from hashhar March 7, 2022 07:58
hashhar
hashhar approved these changes Mar 7, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I understand correctly no failures happened on stress test runs except retries related issue?

LGTM

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Mar 7, 2022

@hashhar Yes, but #11344 will still happen in my guess.

@ebyhr ebyhr merged commit 98b794a into trinodb:master Mar 7, 2022
@ebyhr ebyhr deleted the ebi/phoenix-metadata-get-columns branch March 7, 2022 08:18
@ebyhr ebyhr mentioned this pull request Mar 7, 2022
Closed
@github-actions github-actions bot added this to the 373 milestone Mar 7, 2022
@mosabua mosabua mentioned this pull request Mar 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hashhar hashhar hashhar approved these changes

Assignees

No one assigned

Labels

cla-signed

Milestone

373

Development

Successfully merging this pull request may close these issues.

Phoenix metadata listing may fail with "ERROR 1012 (42M03): Table undefined. tableName=..." in case of concurrent table creation/deletion

3 participants

@ebyhr @findepi @hashhar