Skip to content

Minor refactors to SqlServer type mapping tests#11207

Merged
hashhar merged 1 commit intotrinodb:masterfrom
tangjiangling:minor-fixes-in-sql-server-type-mapping-tests
Feb 26, 2022
Merged

Minor refactors to SqlServer type mapping tests#11207
hashhar merged 1 commit intotrinodb:masterfrom
tangjiangling:minor-fixes-in-sql-server-type-mapping-tests

Conversation

@tangjiangling
Copy link
Copy Markdown
Member

@tangjiangling tangjiangling commented Feb 26, 2022

  • Move sqlServer to BaseSqlServerTypeMapping
  • Remove onRemoteDatabase in TestSqlServerTypeMapping
  • Implement onRemoteDatabase in BaseSqlServerTypeMapping

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Refactoring.

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

SqlServer connector type mapping tests.

How would you describe this change to a non-technical end user or system administrator?

N/A.

Related issues, pull requests, and links

#11148 (comment)

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

- Move `sqlServer` to BaseSqlServerTypeMapping
- Remove onRemoteDatabase in TestSqlServerTypeMapping
- Implement onRemoteDatabase in BaseSqlServerTypeMapping
@cla-bot cla-bot bot added the cla-signed label Feb 26, 2022
@tangjiangling tangjiangling requested a review from ebyhr February 26, 2022 02:11
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@hashhar hashhar merged commit 4ddb575 into trinodb:master Feb 26, 2022
@github-actions github-actions bot added this to the 372 milestone Feb 26, 2022
@tangjiangling tangjiangling deleted the minor-fixes-in-sql-server-type-mapping-tests branch February 26, 2022 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants