Merged
Conversation
findepi
approved these changes
Feb 25, 2022
Member
arhimondr
approved these changes
Feb 25, 2022
losipiuk
force-pushed
the
lukaszos/drop-unneeded-taskmanager-interface-0c26aa
branch
from
4891e44 to
372247a
Compare
electrum
reviewed
Feb 28, 2022
| @@ -84,7 +84,7 @@ | |||
| import static java.util.concurrent.Executors.newScheduledThreadPool; | |||
|
|
|||
| public class SqlTaskManager | |||
Member
There was a problem hiding this comment.
Should we rename this to TaskManager to minimize other changes?
Make failAbandonedTasks() private since it's not meant to be used externally.
Member
Author
There was a problem hiding this comment.
Should we rename this to TaskManager to minimize other changes?
Actually (if done in a single commit) it will be recorded by diff as a bigger change, as TaskManager.java already exists; it will be treated as an edit of TaskManager.java, not a rename-with-changes of SqlTaskManager.java to TaskManager.java
Member
Author
There was a problem hiding this comment.
Make failAbandonedTasks() private since it's not meant to be used externally.
done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refactor - no release notes/docs needed