Skip to content

Bump bytecode dependency version to 1.4 #11175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
findepi merged 1 commit into from
Feb 25, 2022
+12 −10
Merged

Bump bytecode dependency version to 1.4 #11175

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions core/trino-main/src/main/java/io/trino/operator/scalar/MapTransformValuesFunction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,14 +233,16 @@ private static MethodHandle generateTransform(Type keyType, Type valueType, Type
"Close builder before throwing to avoid subsequent calls finding it in an inconsistent state if we are in a TRY() call.",
transformedValueElement.set(function.invoke("apply", Object.class, keyElement.cast(Object.class), valueElement.cast(Object.class))
.cast(transformedValueJavaType)),
new BytecodeBlock()
.append(mapBlockBuilder.invoke("closeEntry", BlockBuilder.class).pop())
.append(pageBuilder.invoke("declarePosition", void.class))
.putVariable(transformationException)
.append(invokeStatic(Throwables.class, "throwIfUnchecked", void.class, transformationException))
.append(newInstance(RuntimeException.class, transformationException))
.throwObject(),
type(Throwable.class)))
ImmutableList.of(
new TryCatch.CatchBlock(
new BytecodeBlock()
.append(mapBlockBuilder.invoke("closeEntry", BlockBuilder.class).pop())
.append(pageBuilder.invoke("declarePosition", void.class))
.putVariable(transformationException)
.append(invokeStatic(Throwables.class, "throwIfUnchecked", void.class, transformationException))
.append(newInstance(RuntimeException.class, transformationException))
.throwObject(),
ImmutableList.of(type(Throwable.class))))))
.append(keySqlType.invoke("appendTo", void.class, block, position, blockBuilder))
.append(writeTransformedValueElement)));

Expand Down
4 changes: 2 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -684,7 +684,7 @@
<dependency>
<groupId>io.airlift</groupId>
<artifactId>bytecode</artifactId>
<version>1.2</version>
<version>1.4</version>
</dependency>

<dependency>
Expand Down Expand Up @@ -1558,7 +1558,7 @@
<dependency>
<groupId>org.ow2.asm</groupId>
<artifactId>asm</artifactId>
<version>9.1</version>
<version>9.2</version>
</dependency>

<dependency>
Expand Down