Skip to content

Small test code cleanup #11164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 4 commits into from
Feb 24, 2022
+138 −151
Merged

Small test code cleanup #11164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c2cf7ef
Remove redundant try-finally in some tests
findepi Feb 23, 2022
412e91a
Move testOptimizeForPartitionedTable up
findepi Feb 23, 2022
4fd22fc
Drop test table
findepi Feb 23, 2022
128e1d5
Fix indentation
findepi Feb 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion plugin/trino-hive/src/test/java/io/trino/plugin/hive/BaseHiveConnectorTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7889,8 +7889,9 @@ public void testOptimize()

// compact with low threshold; nothing should change
assertUpdate(optimizeEnabledSession, "ALTER TABLE " + tableName + " EXECUTE optimize(file_size_threshold => '10B')");

assertThat(getTableFiles(tableName)).hasSameElementsAs(compactedFiles);

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand All @@ -7916,6 +7917,8 @@ public void testOptimizeWithWriterScaling()
Set<String> compactedFiles = getTableFiles(tableName);
assertThat(compactedFiles).hasSize(1);
assertThat(intersection(initialFiles, compactedFiles)).isEmpty();

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand Down Expand Up @@ -7973,6 +7976,8 @@ public void testOptimizeWithPartitioning()
Set<String> compactedFiles = getTableFiles(tableName);
assertThat(compactedFiles).hasSize(partitionsCount);
assertThat(intersection(initialFiles, compactedFiles)).isEmpty();

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand All @@ -7997,6 +8002,8 @@ public void testOptimizeWithBucketing()

assertThat(getTableFiles(tableName)).hasSameElementsAs(initialFiles);
assertNationNTimes(tableName, insertCount);

assertUpdate("DROP TABLE " + tableName);
}

@Test
Expand All @@ -8016,6 +8023,8 @@ public void testOptimizeHiveSystemTable()

assertThatThrownBy(() -> computeActual(optimizeEnabledSession(), format("ALTER TABLE \"%s$partitions\" EXECUTE optimize(file_size_threshold => '10kB')", tableName)))
.hasMessage("This connector does not support table procedures");

assertUpdate("DROP TABLE " + tableName);
}

private Session optimizeEnabledSession()
Expand Down
Loading