Skip to content

Replace row-wise DefaultPagePartitioner with ColumnarPagePartitioner #11146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sopel39 merged 5 commits into from
Mar 4, 2022
Merged

Replace row-wise DefaultPagePartitioner with ColumnarPagePartitioner #11146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d3a79e8
Revert "Modularize PagePartitioner"
lukasz-stec Feb 24, 2022
f5b483a
Pollute jit profile in the benchmark setup
lukasz-stec Feb 22, 2022
755cbf4
Rename DefaultPagePartitioner to PagePartitioner
lukasz-stec Feb 24, 2022
6fa20a2
Implement column-wise approach in the PagePartitioner
lukasz-stec Feb 17, 2022
7a775c8
empty
lukasz-stec Mar 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions core/trino-main/src/main/java/io/trino/operator/OperatorFactories.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,8 @@
*/
package io.trino.operator;

import io.airlift.units.DataSize;
import io.trino.execution.buffer.OutputBuffer;
import io.trino.operator.join.JoinBridgeManager;
import io.trino.operator.join.LookupSourceFactory;
import io.trino.spi.predicate.NullableValue;
import io.trino.spi.type.Type;
import io.trino.spiller.PartitioningSpillerFactory;
import io.trino.sql.planner.plan.PlanNodeId;
Expand Down Expand Up @@ -84,14 +81,4 @@ OperatorFactory fullOuterJoin(
OptionalInt totalOperatorsCount,
PartitioningSpillerFactory partitioningSpillerFactory,
BlockTypeOperators blockTypeOperators);

OutputFactory partitionedOutput(
TaskContext taskContext,
PartitionFunction partitionFunction,
List<Integer> partitionChannels,
List<Optional<NullableValue>> partitionConstants,
boolean replicateNullsAndAny,
OptionalInt nullChannel,
OutputBuffer outputBuffer,
DataSize maxPagePartitioningBufferSize);
}
25 changes: 0 additions & 25 deletions core/trino-main/src/main/java/io/trino/operator/TrinoOperatorFactories.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,11 @@
*/
package io.trino.operator;

import io.airlift.units.DataSize;
import io.trino.execution.buffer.OutputBuffer;
import io.trino.operator.join.JoinBridgeManager;
import io.trino.operator.join.JoinProbe.JoinProbeFactory;
import io.trino.operator.join.LookupJoinOperatorFactory;
import io.trino.operator.join.LookupJoinOperatorFactory.JoinType;
import io.trino.operator.join.LookupSourceFactory;
import io.trino.spi.predicate.NullableValue;
import io.trino.spi.type.Type;
import io.trino.spiller.PartitioningSpillerFactory;
import io.trino.sql.planner.plan.PlanNodeId;
Expand All @@ -36,7 +33,6 @@
import static io.trino.operator.join.LookupJoinOperatorFactory.JoinType.INNER;
import static io.trino.operator.join.LookupJoinOperatorFactory.JoinType.LOOKUP_OUTER;
import static io.trino.operator.join.LookupJoinOperatorFactory.JoinType.PROBE_OUTER;
import static io.trino.operator.output.PartitionedOutputOperator.PartitionedOutputFactory;

public class TrinoOperatorFactories
implements OperatorFactories
Expand Down Expand Up @@ -165,27 +161,6 @@ public OperatorFactory fullOuterJoin(
blockTypeOperators);
}

@Override
public OutputFactory partitionedOutput(
TaskContext taskContext,
PartitionFunction partitionFunction,
List<Integer> partitionChannels,
List<Optional<NullableValue>> partitionConstants,
boolean replicateNullsAndAny,
OptionalInt nullChannel,
OutputBuffer outputBuffer,
DataSize maxPagePartitioningBufferSize)
{
return new PartitionedOutputFactory(
partitionFunction,
partitionChannels,
partitionConstants,
replicateNullsAndAny,
nullChannel,
outputBuffer,
maxPagePartitioningBufferSize);
}

private static List<Integer> rangeList(int endExclusive)
{
return IntStream.range(0, endExclusive)
Expand Down
271 changes: 0 additions & 271 deletions core/trino-main/src/main/java/io/trino/operator/output/DefaultPagePartitioner.java
View file
Open in desktop

This file was deleted.

Loading