Skip to content

Only mark dictionaries as compacted when they are not nested#11145

Merged
sopel39 merged 2 commits intotrinodb:masterfrom
starburstdata:ks/compact
Feb 23, 2022
Merged

Only mark dictionaries as compacted when they are not nested#11145
sopel39 merged 2 commits intotrinodb:masterfrom
starburstdata:ks/compact

Conversation

@sopel39
Copy link
Copy Markdown
Member

@sopel39 sopel39 commented Feb 22, 2022

Description

Is this change a fix, improvement, new feature, refactoring, or other?

Fixes #11080

Is this a change to the core query engine, a connector, client library, or the SPI interfaces? (be specific)

How would you describe this change to a non-technical end user or system administrator?

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.

Release notes

( ) No release notes entries required.
(x) Release notes entries required with the following suggested text:

# General
Fix certain queries failing due to dictionary compacting error. ({issue}`11080`)

@sopel39 sopel39 requested a review from losipiuk February 22, 2022 12:41
@cla-bot cla-bot bot added the cla-signed label Feb 22, 2022
@raunaqmorarka
Copy link
Copy Markdown
Member

Can we have a test ?

@sopel39 sopel39 merged commit e2cdb3f into trinodb:master Feb 23, 2022
@sopel39 sopel39 deleted the ks/compact branch February 23, 2022 10:21
@sopel39 sopel39 mentioned this pull request Feb 23, 2022
@github-actions github-actions bot added this to the 372 milestone Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

3 participants