Move Iceberg failure recovery test to separate job#11142
Merged
losipiuk merged 2 commits intotrinodb:masterfrom Feb 23, 2022
Merged
Move Iceberg failure recovery test to separate job#11142losipiuk merged 2 commits intotrinodb:masterfrom
losipiuk merged 2 commits intotrinodb:masterfrom
Conversation
losipiuk
force-pushed
the
lo/extract-iceberg-failure-recovery-tests
branch
from
a2e8e33 to
7630734
Compare
aczajkowski
reviewed
Feb 22, 2022
plugin/trino-iceberg/pom.xml
Outdated
Member
There was a problem hiding this comment.
Shouldn't we leave them in plugin management section ? Or you just consider it as duplicate.
Which seems it might be 🤔
Member
Author
There was a problem hiding this comment.
IDK. I copied approach form pom.xml for Hive connector.
Member
Author
There was a problem hiding this comment.
Damn - it looks like excluded tests still executed for default profile ...
losipiuk
force-pushed
the
lo/extract-iceberg-failure-recovery-tests
branch
from
7630734 to
f618dcb
Compare
arhimondr
approved these changes
Feb 22, 2022
findepi
approved these changes
Feb 23, 2022
plugin/trino-iceberg/pom.xml
Outdated
Member
There was a problem hiding this comment.
Why this appears as a change here?
did you mean a prep commit?
Member
Author
There was a problem hiding this comment.
It is verbatim move from -> to default profile
Member
Author
There was a problem hiding this comment.
I extracted separate commit. But it still shows in diff as it is different level of indentation.
losipiuk
force-pushed
the
lo/extract-iceberg-failure-recovery-tests
branch
from
f618dcb to
d9f3939
Compare
losipiuk
force-pushed
the
lo/extract-iceberg-failure-recovery-tests
branch
from
d9f3939 to
f40b7ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move Iceberg failure recovery test to separate job
test refactoring
test code, iceberg connector
N/A
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: