Skip to content

Disable predicate pushdown on ARRAY(CHAR) type in Phoenix#11133

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/phoenix-disable-array-pushdown
Feb 22, 2022
Merged

Disable predicate pushdown on ARRAY(CHAR) type in Phoenix#11133
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/phoenix-disable-array-pushdown

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Feb 22, 2022

Description

Disable predicate pushdown on ARRAY(CHAR) type in Phoenix to fix query failure.

Related issues, pull requests, and links

Documentation

(x) No documentation is needed.

Release notes

(x) Release notes entries required with the following suggested text:

# Phoenix
* Fix query failures when applying predicates on `array(char)` type columns. ({issue}`10451`)

Fix query failure for predicate pushdown on ARRAY(CHAR) type.
@cla-bot cla-bot bot added the cla-signed label Feb 22, 2022
@ebyhr ebyhr requested a review from hashhar February 22, 2022 03:39
Copy link
Copy Markdown
Member

@hashhar hashhar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

It seems pushdown never worked and queries failed instead. Makes sense to me.

@hashhar
Copy link
Copy Markdown
Member

hashhar commented Feb 22, 2022

Would this be a better release note? Since pushdown never existed for ARRAY(char).

# Phoenix
* Fix query failures when applying predicates on `array(char)` type columns. ({issue}`10451`)

@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Feb 22, 2022

@hashhar The suggested release note looks better. Thanks!

@ebyhr ebyhr merged commit c199fac into trinodb:master Feb 22, 2022
@ebyhr ebyhr deleted the ebi/phoenix-disable-array-pushdown branch February 22, 2022 07:29
@ebyhr ebyhr mentioned this pull request Feb 22, 2022
@github-actions github-actions bot added this to the 372 milestone Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

Predicate pushdown on ARRAY(char) type in Phoenix 4 & 5 connector throws an exception

2 participants