Support for killing individual task if cluster is out of memory#11129
Merged
losipiuk merged 5 commits intotrinodb:masterfrom Mar 8, 2022
Merged
Support for killing individual task if cluster is out of memory#11129losipiuk merged 5 commits intotrinodb:masterfrom
losipiuk merged 5 commits intotrinodb:masterfrom
Conversation
c818b5a to
d868290
Compare
arhimondr
reviewed
Mar 1, 2022
Contributor
arhimondr
left a comment
There was a problem hiding this comment.
Looks good to me % comments
core/trino-main/src/main/java/io/trino/execution/scheduler/SqlQueryScheduler.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/memory/MemoryResource.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/memory/MemoryResource.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/RemoteTask.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/execution/scheduler/SqlQueryScheduler.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/memory/ClusterMemoryManager.java
Outdated
Show resolved
Hide resolved
d868290 to
8095e10
Compare
Member
Author
|
AC |
arhimondr
approved these changes
Mar 2, 2022
e0545dd to
b9797dd
Compare
Member
Author
|
@martint could you maybe take a look? |
Member
Author
NVM - comment was meant for different PR |
linzebing
approved these changes
Mar 4, 2022
core/trino-main/src/main/java/io/trino/memory/ClusterMemoryManager.java
Outdated
Show resolved
Hide resolved
core/trino-main/src/main/java/io/trino/memory/ClusterMemoryManager.java
Outdated
Show resolved
Hide resolved
...no-main/src/test/java/io/trino/memory/TestTotalReservationOnBlockedNodesLowMemoryKiller.java
Outdated
Show resolved
Hide resolved
b9797dd to
e90a233
Compare
Extend MemoryInfo data structure passed from workers to coordinator via `v1/memory` resource with memory reservation for all tasks which are running as part of queries with task-level retries enabled. The extra information is needed for implementing task aware cluster out of memory killer.
e90a233 to
2cb6895
Compare
Member
Author
|
CI: #10631 ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support for killing individual task if cluster is out of memory.
Individual tasks will be killed for queries which are run with task-level retries.
Currently only supported if default low memory killer policy is used (total-reservation-on-blocked-nodes).
improvement to new feature
core query engine
N/A
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: