Skip to content

Use proper SQL identifier semantics for named call arguments#11123

Closed
kasiafi wants to merge 1 commit intotrinodb:masterfrom
kasiafi:309CallArgumentName
Closed

Use proper SQL identifier semantics for named call arguments#11123
kasiafi wants to merge 1 commit intotrinodb:masterfrom
kasiafi:309CallArgumentName

Conversation

@kasiafi
Copy link
Copy Markdown
Member

@kasiafi kasiafi commented Feb 21, 2022

POC fix for #11120. Needs further discussion because it causes backwards incompatibility in argument resolution.

@findepi
Copy link
Copy Markdown
Member

findepi commented Feb 21, 2022

If we go this route, we should also change procedures and table procedures parameter declarations, to have parameters in uppercase.

cc @losipiuk @homar

@losipiuk
Copy link
Copy Markdown
Member

If we go this route, we should also change procedures and table procedures parameter declarations, to have parameters in uppercase.

cc @losipiuk @homar

Yeah - exactly. I think it makes sense. @findepi do you see any realistic backward compatibility issues with this change? (i do not).

@findepi
Copy link
Copy Markdown
Member

findepi commented Feb 23, 2022

I think that would be fine from practical perspective.
cc @martint on the specwise aspect

@kasiafi if you want, i can take it from here.

Also, as a transition period, we could require procedures params to be uppercase, so that procedure implementors are forced to update, to keep queries from failing. And then unblock case sensitive params after couple releases.

@kasiafi
Copy link
Copy Markdown
Member Author

kasiafi commented Feb 23, 2022

@findepi feel free to take it.

@findepi
Copy link
Copy Markdown
Member

findepi commented Feb 23, 2022

-> #11163

@findepi
Copy link
Copy Markdown
Member

findepi commented Mar 16, 2022

Replaced by #11163

@findepi findepi closed this Mar 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants