Support guessing BinData type as varbinary in MongoDB #11122
Merged
ebyhr merged 3 commits intotrinodb:masterfrom Feb 23, 2022
Merged
Support guessing BinData type as varbinary in MongoDB #11122ebyhr merged 3 commits intotrinodb:masterfrom
ebyhr merged 3 commits intotrinodb:masterfrom
Conversation
This supports BinData type in DBRef field.
hashhar
approved these changes
Feb 22, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
LGTM.
Discussed offline regarding the test using ("invalid/unexpected") DBRefs - it can be tackled separately.
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Support guessing BinData type as varbinary in MongoDB
Documentation
(x) Documentation issue #11121 is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: