Define additional repos only in submodules using them#11119
Merged
findepi merged 1 commit intotrinodb:masterfrom Feb 23, 2022
Merged
Define additional repos only in submodules using them#11119findepi merged 1 commit intotrinodb:masterfrom
findepi merged 1 commit intotrinodb:masterfrom
Conversation
hashhar
approved these changes
Feb 21, 2022
By moving rarely used custom repositories to modules where they're actually used, this is supposed to avoid hitting them for every artifact.
518bef9 to
d4cde7a
Compare
Member
Author
|
trino-hive failure looks like a flake, it passed in the previous run and I only reworded the commit message now (without a rebase). But there's also a bunch of: so maybe we could somehow tune the configs to fit the runners or there's a leak in tests. Should I investigate further? |
Member
apache/maven-surefire#407 might be related. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
By moving rarely used custom repositories to modules where they're actually used, this is supposed to avoid hitting them for every artifact.
Custom repositories are checked before central, defined in the Super POM, as described here: https://maven.apache.org/guides/mini/guide-multiple-repositories.html#repository-order
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: