Fix Iceberg statistics accumulation after schema evolution#11091
Fix Iceberg statistics accumulation after schema evolution#11091findepi merged 1 commit intotrinodb:masterfrom
Conversation
|
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Curt.
|
c15b82d to
413f25f
Compare
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergStatistics.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/test/java/io/trino/plugin/iceberg/TestIcebergSystemTables.java
Outdated
Show resolved
Hide resolved
plugin/trino-iceberg/src/main/java/io/trino/plugin/iceberg/IcebergStatistics.java
Outdated
Show resolved
Hide resolved
413f25f to
9c8fb86
Compare
|
Currently we loop through |
9c8fb86 to
903e526
Compare
|
@alexjo2144 Any more comments, can we merge this? |
alexjo2144
left a comment
There was a problem hiding this comment.
Code changes look good, just need one tweak to the test still.
We need a maintainer to take a look though, I can't merge things into Trino. @findepi ?
903e526 to
cedd3ec
Compare
updated |
|
@findepi Any other suggestions? |
alexjo2144
left a comment
There was a problem hiding this comment.
Looks good to me. I'd probably just word the commit/title a little differently.
Maybe something like "Fix Iceberg statistics accumulation after schema evolution"
cedd3ec to
0c346b5
Compare
|
Merged, thank you @BlueStalker for your PR! |
This fixes the issues when there is a schema change (drop or change column) on iceberg tables, then the partitions schema table query failed with verification error. With this fix, it will return the rest columns and escape the failed ones.
Before the change, the query on "$partitions" will fail if there are column dropped, now it is just escape the column