Skip to content

Make close on streaming S3 OutputStream idempotent #11089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
losipiuk merged 1 commit into from
Feb 18, 2022
Merged

Make close on streaming S3 OutputStream idempotent #11089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions plugin/trino-hive/src/main/java/io/trino/plugin/hive/s3/TrinoS3FileSystem.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1481,6 +1481,7 @@ private static class TrinoS3StreamingOutputStream
private byte[] buffer;
private int bufferSize;

private boolean closed;
private boolean failed;
// Mutated and read by main thread; mutated just before scheduling upload to background thread (access does not need to be thread safe)
private boolean multipartUploadStarted;
Expand Down Expand Up @@ -1548,6 +1549,11 @@ public void flush()
public void close()
throws IOException
{
if (closed) {
return;
}
closed = true;

if (failed) {
try {
abortUpload();
Expand Down