Remove support for reserved memory pool#11064
Closed
losipiuk wants to merge 1 commit intotrinodb:masterfrom
Closed
Remove support for reserved memory pool#11064losipiuk wants to merge 1 commit intotrinodb:masterfrom
losipiuk wants to merge 1 commit intotrinodb:masterfrom
Conversation
losipiuk
force-pushed
the
lo/drop-pools
branch
4 times, most recently
from
6267190 to
ceae2c7
Compare
losipiuk
force-pushed
the
lo/drop-pools
branch
from
ceae2c7 to
43e7751
Compare
Member
Author
|
@findepi @arhimondr this one should be good to review. |
Member
findepi
reviewed
Feb 17, 2022
|
|
||
| for (MemoryPoolAssignment assignment : assignments.getAssignments()) { | ||
| if (assignment.getPoolId().equals(GENERAL_POOL)) { | ||
| queryContexts.getUnchecked(assignment.getQueryId()).setMemoryPool(localMemoryManager.getGeneralPool()); |
Member
There was a problem hiding this comment.
is this a good reason to combine this with #11071 together as single change?
Member
Author
There was a problem hiding this comment.
Yeah - could be. I wanted to keep them separate for sake of easier review (the followup is mostly a code cleanup with no user-visible changes). But I may squash them together if you prefer.
Member
Author
There was a problem hiding this comment.
I will close this one then
Member
Author
|
Lets just keep #11071 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Remove support for reserved memory pool.
Mechanism did not prove to be useful and was disabled by default.
Removing to simplify codebase.
Note: as now we have just one memory pool (general) a follow-up PR will remove the memory pools concept altogether.
Improvment
Core query engine
Related issues, pull requests, and links
Fixes #6677
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
(x) Release notes entries required with the following suggested text: