Merged
Conversation
findinpath
approved these changes
Feb 15, 2022
findinpath
reviewed
Feb 15, 2022
lib/trino-collect/src/test/java/io/trino/collect/cache/TestEvictableCache.java
Outdated
Show resolved
Hide resolved
Fix `EvictableCache`'s `asMap.replace(key, oldValue, newValue)`. Before the change, the new value was made immediately inaccessible.
findepi
force-pushed
the
findepi/fix-evictablecache-replace-16aa95
branch
from
07430e1 to
cd8d8e1
Compare
findinpath
approved these changes
Feb 16, 2022
Member
Author
|
CI #10932 |
losipiuk
approved these changes
Feb 16, 2022
Member
|
CI: #10932 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
EvictableCache'sasMap.replace(key, oldValue, newValue).Before the change, the new value was made immediately inaccessible.