Fix race conditions in updating RemoteTaskStats#11044
Merged
losipiuk merged 1 commit intotrinodb:masterfrom Feb 17, 2022
Merged
Fix race conditions in updating RemoteTaskStats#11044losipiuk merged 1 commit intotrinodb:masterfrom
losipiuk merged 1 commit intotrinodb:masterfrom
Conversation
Member
|
@raunaqmorarka is this related to #11039 ? |
Member
Author
|
@findepi I don't think this will resolve the |
losipiuk
reviewed
Feb 17, 2022
core/trino-main/src/main/java/io/trino/server/remotetask/ContinuousTaskStatusFetcher.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Feb 17, 2022
core/trino-main/src/main/java/io/trino/server/remotetask/DynamicFiltersFetcher.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Feb 17, 2022
core/trino-main/src/main/java/io/trino/server/remotetask/ContinuousTaskStatusFetcher.java
Outdated
Show resolved
Hide resolved
losipiuk
reviewed
Feb 17, 2022
core/trino-main/src/main/java/io/trino/server/remotetask/TaskInfoFetcher.java
Outdated
Show resolved
Hide resolved
losipiuk
approved these changes
Feb 17, 2022
In the existing implementation, the shared currentRequestStartNanos object may be updated by the next request after the current request future is done but before the callback handler has read the value of currentRequestStartNanos set before the current request was started.
raunaqmorarka
force-pushed
the
nano-race
branch
from
cc64ea6 to
acf0fe1
Compare
arhimondr
approved these changes
Feb 17, 2022
Contributor
arhimondr
left a comment
arhimondr
left a comment
There was a problem hiding this comment.
From what I understand ContinuousTaskStatusFetcher wasn't susceptible to this issue as a new request is always scheduled from a callback, but DynamicFiltersFetcher and TaskInfoFetcher were
losipiuk
approved these changes
Feb 17, 2022
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the existing implementation, the shared currentRequestStartNanos object
may be updated by the next request after the current request future is done
but before the callback handler has read the value of currentRequestStartNanos
set before the current request was started.
General information
Fix
Core query engine
Fixes potential inaccuracies in recording of RemoteTaskStats
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: