Add username and password section#11012
Merged
hashhar merged 1 commit intotrinodb:masterfrom Feb 26, 2022
Merged
Conversation
mosabua
requested changes
Feb 10, 2022
Member
There was a problem hiding this comment.
Note for other reviewers .. we are doing this for now in this PR.. we soon get rid of the other docs and migrate all the info into here.. but one step at a time
Jessie212
force-pushed
the
jt/cli-instructions
branch
from
53691d0 to
ab1e949
Compare
Jessie212
force-pushed
the
jt/cli-instructions
branch
from
ab1e949 to
9011870
Compare
Jessie212
force-pushed
the
jt/cli-instructions
branch
2 times, most recently
from
c26ab99 to
420a053
Compare
mosabua
requested changes
Feb 23, 2022
hashhar
reviewed
Feb 24, 2022
Comment on lines
62
to
64
Member
There was a problem hiding this comment.
This part about username and it's default value isn't applicable only when password auth is enabled. So it should precede this section.
Member
There was a problem hiding this comment.
Good point .. how about we leave this as is in this PR.. but move it into the table of options we are working on in a follow up PR @hashhar ..
Member
There was a problem hiding this comment.
Fine with me, can you link me to the other PR so that I remember to make sure this is applied?
Contributor
Author
There was a problem hiding this comment.
Jessie212
force-pushed
the
jt/cli-instructions
branch
2 times, most recently
from
9992337 to
93e6d63
Compare
Jessie212
force-pushed
the
jt/cli-instructions
branch
from
93e6d63 to
63d1aab
Compare
mosabua
approved these changes
Feb 26, 2022
hashhar
approved these changes
Feb 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
General information
Improvement.
Documentation only.
Add username and password section
Related issues, pull requests, and links
Documentation
( ) No documentation is needed.
( ✅) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ✅) No release notes entries required.
( ) Release notes entries required with the following suggested text: