Closed
Conversation
kokosing
approved these changes
Feb 3, 2022
| .withMaxDuration(Duration.ofSeconds(4)) | ||
| .withBackoff(100, 500, MILLIS) | ||
| .handleResultIf(code -> code != HTTP_OK)) | ||
| .handleResultIf(code -> code >= 500)) |
Member
Author
|
duplication of #10929 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's a bug in a client, as it's too restrictive expecting for the server to return
200 OKHttp Code to be returned on ack token, when in reality the endpoint returns204 NO_CONTENT. This causes token mechanism to hang for 4s before it finishes.Fix tries to handle this from both sides:
/oauth2/token/{authId} DELETEresponse to return 200 with body, to meet the expectations of older and different clients