Skip to content

Mark tests that write using Hive as flaky in TestHiveStorageFormats #10926

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashhar merged 1 commit into from
Feb 3, 2022
Merged

Mark tests that write using Hive as flaky in TestHiveStorageFormats #10926

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions ...trino-product-tests/src/main/java/io/trino/tests/product/hive/TestHiveStorageFormats.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@
import io.trino.tempto.query.QueryExecutionException;
import io.trino.tempto.query.QueryExecutor.QueryParam;
import io.trino.tempto.query.QueryResult;
import io.trino.testng.services.Flaky;
import io.trino.tests.product.utils.JdbcDriverUtils;
import org.apache.parquet.hadoop.ParquetWriter;
import org.assertj.core.api.Assertions;
Expand Down Expand Up @@ -65,6 +66,8 @@
import static io.trino.tests.product.TestGroups.HMS_ONLY;
import static io.trino.tests.product.TestGroups.STORAGE_FORMATS;
import static io.trino.tests.product.TestGroups.STORAGE_FORMATS_DETAILED;
import static io.trino.tests.product.hive.HiveProductTest.ERROR_COMMITTING_WRITE_TO_HIVE_ISSUE;
import static io.trino.tests.product.hive.HiveProductTest.ERROR_COMMITTING_WRITE_TO_HIVE_MATCH;
import static io.trino.tests.product.hive.util.TemporaryHiveTable.randomTableSuffix;
import static io.trino.tests.product.utils.JdbcDriverUtils.setSessionProperty;
import static io.trino.tests.product.utils.QueryExecutors.onHive;
Expand Down Expand Up @@ -458,6 +461,7 @@ public void testInsertAndSelectWithNullFormat(StorageFormat storageFormat)
}

@Test(dataProvider = "storageFormatsWithZeroByteFile", groups = STORAGE_FORMATS_DETAILED)
@Flaky(issue = ERROR_COMMITTING_WRITE_TO_HIVE_ISSUE, match = ERROR_COMMITTING_WRITE_TO_HIVE_MATCH)
public void testSelectFromZeroByteFile(StorageFormat storageFormat)
{
String tableName = format(
Expand All @@ -478,6 +482,7 @@ public void testSelectFromZeroByteFile(StorageFormat storageFormat)
}

@Test(dataProvider = "storageFormatsWithNullFormat", groups = STORAGE_FORMATS_DETAILED)
@Flaky(issue = ERROR_COMMITTING_WRITE_TO_HIVE_ISSUE, match = ERROR_COMMITTING_WRITE_TO_HIVE_MATCH)
public void testSelectWithNullFormat(StorageFormat storageFormat)
{
String nullFormat = "null_value";
Expand Down Expand Up @@ -635,6 +640,7 @@ private void testNestedFields(String format, Engine writer)
}

@Test(groups = STORAGE_FORMATS_DETAILED)
@Flaky(issue = ERROR_COMMITTING_WRITE_TO_HIVE_ISSUE, match = ERROR_COMMITTING_WRITE_TO_HIVE_MATCH)
public void testOrcStructsWithNonLowercaseFields()
throws SQLException
{
Expand Down Expand Up @@ -671,6 +677,7 @@ public void testOrcStructsWithNonLowercaseFields()
}

@Test(dataProvider = "storageFormatsWithNanosecondPrecision", groups = STORAGE_FORMATS_DETAILED)
@Flaky(issue = ERROR_COMMITTING_WRITE_TO_HIVE_ISSUE, match = ERROR_COMMITTING_WRITE_TO_HIVE_MATCH)
public void testTimestampCreatedFromHive(StorageFormat storageFormat)
{
String tableName = createSimpleTimestampTable("timestamps_from_hive", storageFormat);
Expand Down Expand Up @@ -704,6 +711,7 @@ public void testTimestampCreatedFromTrino(StorageFormat storageFormat)
}

@Test(dataProvider = "storageFormatsWithNanosecondPrecision", groups = STORAGE_FORMATS_DETAILED)
@Flaky(issue = ERROR_COMMITTING_WRITE_TO_HIVE_ISSUE, match = ERROR_COMMITTING_WRITE_TO_HIVE_MATCH)
public void testStructTimestampsFromHive(StorageFormat format)
{
String tableName = createStructTimestampTable("hive_struct_timestamp", format);
Expand Down