Increase timeout when testing Docker image#10924
Merged
hashhar merged 1 commit intotrinodb:masterfrom Feb 3, 2022
Merged
Conversation
hashhar
force-pushed
the
hashhar/debug-docker-image
branch
from
bfa7768 to
cd5738b
Compare
Member
Author
|
Ah, it was flaky earlier too. We have a timeout of ~150 seconds to wait for docker image to start. I'll update the timeout to give more breathing room. |
The ARM64 Docker image runs under emulation and hence can take time to start up. The existing timeout of ~150 seconds is too close to the amount of time it takes for the image to start and hence introduces occasional flakiness. We also make available the container's logs in timeouts to help debug if needed.
hashhar
force-pushed
the
hashhar/debug-docker-image
branch
from
cd5738b to
8c70bd4
Compare
hashhar
changed the title
ebyhr
approved these changes
Feb 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ARM64 Docker image runs under emulation and hence can take time to
start up. The existing timeout of ~150 seconds is too close to the
amount of time it takes for the image to start and hence introduces
occasional flakiness.
We also make available the container's logs in timeouts to help debug if
needed.