Skip to content

Fix compile error due to missing constant #10920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hashhar merged 1 commit into from
Feb 3, 2022
Merged

Fix compile error due to missing constant #10920

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions core/trino-main/src/main/java/io/trino/type/DecimalCasts.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@
import io.trino.spi.type.DecimalType;
import io.trino.spi.type.Decimals;
import io.trino.spi.type.Int128;
import io.trino.spi.type.Int128Math;
import io.trino.spi.type.StandardTypes;
import io.trino.spi.type.TypeSignature;
import io.trino.spi.type.VarcharType;
Expand All @@ -53,6 +52,7 @@
import static io.trino.spi.type.DoubleType.DOUBLE;
import static io.trino.spi.type.Int128.ZERO;
import static io.trino.spi.type.Int128Math.multiply;
import static io.trino.spi.type.Int128Math.powerOfTen;
import static io.trino.spi.type.Int128Math.rescale;
import static io.trino.spi.type.IntegerType.INTEGER;
import static io.trino.spi.type.RealType.REAL;
Expand Down Expand Up @@ -113,7 +113,7 @@ private static SqlScalarFunction castFunctionFromDecimalTo(TypeSignature to, Str
tenToScale = longTenToNth(DecimalConversions.intScale(scale));
}
else {
tenToScale = Int128Math.POWERS_OF_TEN[DecimalConversions.intScale(scale)];
tenToScale = powerOfTen(DecimalConversions.intScale(scale));
}
return ImmutableList.of(precision, scale, tenToScale);
})))
Expand Down Expand Up @@ -147,7 +147,7 @@ private static SqlScalarFunction castFunctionToDecimalFromBuilder(TypeSignature
tenToScale = longTenToNth(resultType.getScale());
}
else {
tenToScale = Int128Math.POWERS_OF_TEN[resultType.getScale()];
tenToScale = powerOfTen(resultType.getScale());
}
return ImmutableList.of(resultType.getPrecision(), resultType.getScale(), tenToScale);
}))).build();
Expand Down
10 changes: 5 additions & 5 deletions core/trino-main/src/main/java/io/trino/type/DecimalSaturatedFloorCasts.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@

import static io.trino.spi.function.OperatorType.SATURATED_FLOOR_CAST;
import static io.trino.spi.type.BigintType.BIGINT;
import static io.trino.spi.type.Int128Math.POWERS_OF_TEN;
import static io.trino.spi.type.Int128Math.floorDiv;
import static io.trino.spi.type.Int128Math.multiply;
import static io.trino.spi.type.Int128Math.negate;
import static io.trino.spi.type.Int128Math.powerOfTen;
import static io.trino.spi.type.Int128Math.subtract;
import static io.trino.spi.type.IntegerType.INTEGER;
import static io.trino.spi.type.SmallintType.SMALLINT;
Expand Down Expand Up @@ -86,13 +86,13 @@ private static Int128 saturatedCast(Int128 value, int sourceScale, int resultPre
{
int scale = resultScale - sourceScale;
if (scale > 0) {
value = multiply(value, POWERS_OF_TEN[scale]);
value = multiply(value, powerOfTen(scale));
}
else if (scale < 0) {
value = floorDiv(value, POWERS_OF_TEN[-scale]);
value = floorDiv(value, powerOfTen(-scale));
}

Int128 maxUnscaledValue = subtract(POWERS_OF_TEN[resultPrecision], Int128.ONE);
Int128 maxUnscaledValue = subtract(powerOfTen(resultPrecision), Int128.ONE);
if (value.compareTo(maxUnscaledValue) > 0) {
return maxUnscaledValue;
}
Expand Down Expand Up @@ -142,7 +142,7 @@ public static long longDecimalToGenericIntegerType(Int128 value, int sourceScale
private static long saturatedCast(Int128 value, int sourceScale, long minValue, long maxValue)
{
if (sourceScale > 0) {
value = floorDiv(value, POWERS_OF_TEN[sourceScale]);
value = floorDiv(value, powerOfTen(sourceScale));
}

if (value.compareTo(Int128.valueOf(maxValue)) > 0) {
Expand Down