Cleanup Glue databases left behind by tests#10901
Closed
findepi wants to merge 1 commit intotrinodb:masterfrom
Closed
Cleanup Glue databases left behind by tests#10901findepi wants to merge 1 commit intotrinodb:masterfrom
findepi wants to merge 1 commit intotrinodb:masterfrom
Conversation
hashhar
reviewed
Feb 2, 2022
| } | ||
|
|
||
| @Test | ||
| public void cleanupOrphanedDatabases() |
Member
There was a problem hiding this comment.
Runs in parallel. Any databases being listed in this test class can then become flaky.
Would be nice to fix those kind of tests (but I didn't spend time to find them).
Alternatively we make this just a method and call in @BeforeClass? (still flaky if other CI runs are running - but lesser chances)
Member
Author
There was a problem hiding this comment.
There is time threshold, so it doesn't matter whether this is @Test or @BeforeClass.
It still runs in parallel with other runs (test processes), that's why i tried to code this defensively.
hashhar
reviewed
Feb 2, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Reminder to not submit from fork to get tests to run.
Member
Author
-> #10903 |
findepi
deleted the
findepi/cleanup-glue-databases-left-behind-by-tests-e49960
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.