Improve Glue failure message when storage descriptor not set#10896
Merged
findepi merged 1 commit intotrinodb:masterfrom Feb 2, 2022
Conversation
Member
Author
|
cc @losipiuk |
alexjo2144
approved these changes
Feb 1, 2022
Member
alexjo2144
left a comment
alexjo2144
left a comment
There was a problem hiding this comment.
Do you have a GH Issue to link?
hashhar
approved these changes
Feb 1, 2022
Member
hashhar
left a comment
hashhar
left a comment
There was a problem hiding this comment.
Please create a GitHub issue and link to it so that we can fix it.
However if the StorageDescriptor is optional how are we supposed to be able to use the table anyway? Does AWS Glue want us to retry our request to get the storage descriptor?
Member
Author
That's why i didn't fix it yet. |
findepi
force-pushed
the
findepi/improve-glue-failure-message-when-storage-descriptor-not-set-6b1b12
branch
from
2d7dd4f to
0b6a6e7
Compare
findepi
deleted the
findepi/improve-glue-failure-message-when-storage-descriptor-not-set-6b1b12
branch
findepi
commented
Feb 2, 2022
| public static Table convertTable(com.amazonaws.services.glue.model.Table glueTable, String dbName) | ||
| { | ||
| requireNonNull(glueTable.getStorageDescriptor(), "Table StorageDescriptor is null"); | ||
| // TODO (https://github.com/trinodb/trino/issues/10902) glueTable.getStorageDescriptor() is an optional field in Glue |
Member
Member
Author
@alexjo2144 not sure if returning "table not found" is the right approach... anyway, maybe we talk this under #10902 . |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.